Hi,
On Fri, 2019-12-06 at 16:17 -0500, Frank Ch. Eigler wrote:
> Presenting testing for the debuginfod .deb/.ddeb support patch, after
> finding a good debian-packaging tutorial, and generating a workable
> basic set of test deb's on a Ubuntu box.
According to Matthias on irc there should be no difference between
Ubuntu and Debian doing this, so this should cover both systems.
> debuginfod: deb support, tests
>
> Using a synthetic .deb/.ddeb from a Ubuntu 18 machine,
> extend the debuginfod testsuite with some .deb processing,
> if the dpkg-deb binary is installed.
Looks good. Thanks.
All buildbot workers should already have the dpkg-deb binary installed.
Two nitpicks below, not very important.
> diff --git a/config/ChangeLog b/config/ChangeLog
> index d71fb39..9b2a408 100644
> --- a/config/ChangeLog
> +++ b/config/ChangeLog
> @@ -1,3 +1,8 @@
> +2019-12-06 Frank Ch. Eigler <f...@redhat.com>
> +
> + * elfutils.spec.in (debuginfod): Add BuildRequire dpkg
> + for deb testing. (Available on Fedora & EPEL, not base RHEL.)
> +
> 2019-11-28 Mark Wielaard <m...@klomp.org>
>
> * elfutils.spec.in (debuginfod): Add an explicit Requires
> diff --git a/config/elfutils.spec.in b/config/elfutils.spec.in
> index 1cdca21..faeb7f8 100644
> --- a/config/elfutils.spec.in
> +++ b/config/elfutils.spec.in
> @@ -35,6 +35,9 @@ BuildRequires: pkgconfig(libarchive) >= 3.1.2
> BuildRequires: bzip2
> # For the run-debuginfod-find.sh test case in %check for
> /usr/sbin/ss
> BuildRequires: iproute
> +%if 0%{?fedora} >= 20
> +BuildRequires: dpkg
> +%endif
> BuildRequires: curl
I believe all public builders (koji, copr, etc) do have epel enabled,
so I would not conditionalize the BuildRequires.
> @@ -205,10 +209,12 @@ rpm_test() {
Maybe rename this archive_test?
Cheers,
Mark
