On Wed, Oct 02, 2013 at 05:48:05PM -0700, Jon Mason wrote: > On Wed, Oct 02, 2013 at 12:49:10PM +0200, Alexander Gordeev wrote: > > Signed-off-by: Alexander Gordeev <[email protected]> > > --- > > drivers/ntb/ntb_hw.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > > index de2062c..eccd5e5 100644 > > --- a/drivers/ntb/ntb_hw.c > > +++ b/drivers/ntb/ntb_hw.c > > @@ -1066,7 +1066,7 @@ static int ntb_setup_msix(struct ntb_device *ndev) > > /* On SNB, the link interrupt is always tied to 4th vector. If > > * we can't get all 4, then we can't use MSI-X. > > */ > > - if (ndev->hw_type != BWD_HW) { > > + if ((rc < SNB_MSIX_CNT) && (ndev->hw_type != BWD_HW)) { > > Nack, this check is unnecessary.
If SNB can do more than SNB_MSIX_CNT MSI-Xs then this check is needed to enable less than maximum MSI-Xs in case the maximum was not allocated. Otherwise SNB will fallback to single MSI instead of multiple MSI-Xs. -- Regards, Alexander Gordeev [email protected] ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
