On Sun, Nov 16, 2008 at 9:46 AM, Dan McDonald <[EMAIL PROTECTED]> wrote: > On Sun, Nov 16, 2008 at 07:43:36AM -0600, Mike Gerdts wrote: >> I've posted an updated code review that adds a test case. I've >> verified a full clobber build, that bfu delivers the new test case, >> and that the test case fails without the fix and succeeds with the >> fix. > > I'm certainly fine with the dtri.c fix (check env ONCE, then set state), and > you can claim me as a reviewer for that file. Let's just hope there aren't > any grinning weirdos out there who DEPEND on being able to change > DTRACE_DOF_INIT_DEBUG in the middle of a run. :) (You know there's probably > at least one person out there who'll complain...)
Thanks for taking a look. I had thought about that case as well, and figured nearly everyone else would agree that the person that complained was a weirdo. As best as I can tell, this environment variable is not documented as an interface and it is new enough that google (after eliminating duplicates) shows only 8 references. Five of those references are related to the initial problem that led to the bug report or are related to the fix. > You should get a 2nd okay on the test script, however. I see how it works, > but I'm not familiar enough with .../dtrace/test/... to know if your script > fits in with the big picture of how tests are done. The test script started out as a different one from the test suite that also needed to create a USDT provider. The changes were: - Specify $PATH instead of providing full path to some commands - Use mktemp(1) instead of introducing symlink vulnerabilities - Clean up temporary directory even if the test fails - Changed the provider name from something that seemed to be specific to the test I copied it from - Got rid of the ident string - Respect CC environment variable during compile I noticed that I missed the bits to get it into the SUNWdtrt package and am in the process of another full build in preparation for generating an updated webrev. Thanks for the review. -- Mike Gerdts http://mgerdts.blogspot.com/ _______________________________________________ dtrace-discuss mailing list dtrace-discuss@opensolaris.org
