On Sun, Nov 16, 2008 at 07:43:36AM -0600, Mike Gerdts wrote: > I've posted an updated code review that adds a test case. I've > verified a full clobber build, that bfu delivers the new test case, > and that the test case fails without the fix and succeeds with the > fix.
I'm certainly fine with the dtri.c fix (check env ONCE, then set state), and you can claim me as a reviewer for that file. Let's just hope there aren't any grinning weirdos out there who DEPEND on being able to change DTRACE_DOF_INIT_DEBUG in the middle of a run. :) (You know there's probably at least one person out there who'll complain...) You should get a 2nd okay on the test script, however. I see how it works, but I'm not familiar enough with .../dtrace/test/... to know if your script fits in with the big picture of how tests are done. Dan _______________________________________________ dtrace-discuss mailing list dtrace-discuss@opensolaris.org
