[
https://jira.duraspace.org/browse/DS-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26725#comment-26725
]
Tim Donohue commented on DS-1356:
---------------------------------
Ivan & all,
Admittedly, I hadn't thought it through much more than realizing that the only
reason that the 'dspace-oai' JAR needs to be placed in the final [dspace]/lib/
directory is so that the org.dspace.xoai.app.XOAI class is accessible to the
"./bin/dspace oai" command.
So, it's basically a *single* class that is needed, and in order to get it, the
entire JAR is copied over.
Although this isn't a huge deal (it's minor messiness), obviously it could be
much cleaner if we found a way to refactor things so that the single class was
moved either to dspace-api (though as you rightly point out, this would likely
make dspace-api depend on dspace-oai and that would definitely cause issues),
or move all "launcher" classes to their own maven project. (Or just rework the
launcher to use Spring dependency injection perhaps?)
Either way though, I don't think this is a big deal right now. I'd say this
ticket could likely just be closed as "won't fix". I've already added some
comments to the POM in question detailing why the 'dspace-oai' dependency needs
to be there. We could always revisit this in 4.0 as needed.
> What is the dspace-oai dependency in dspace/pom.xml ?
> -----------------------------------------------------
>
> Key: DS-1356
> URL: https://jira.duraspace.org/browse/DS-1356
> Project: DSpace
> Issue Type: Bug
> Affects Versions: 3.0
> Reporter: Robin Taylor
> Assignee: Mark Diggory
> Labels: oai
> Fix For: 3.0
>
>
> More of a question and probably a daft one, but I don't understand the
> dependency...
> <dependency>
> <groupId>org.dspace</groupId>
> <artifactId>dspace-oai</artifactId>
> <type>jar</type>
> <classifier>classes</classifier>
> </dependency>
> in dspace/pom.xml. Does this jar exist ?
> Cheers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
