Hi João, I'm not against that idea.
But, I will point out that would mean the XOAI/OAI 2.0 configs would be split over three separate locations: /config/modules/oai.cfg /config/crosswalks/oai/* /config/xoai.xml Obviously if we document things well this isn't a huge deal, but we need to make it very clear so that people aren't confused by the fact that you have to go the three different places based on what you want to configure about OAI 2.0. I guess I still don't understand why it's bad to have the xoai.xml just sit under /config/crosswalks/oai/ , but if there's a real reason why that is bad, then I'm fine with it being elsewhere. Anyone have strong feelings one way or the other? - Tim On 9/24/2012 11:37 AM, João Melo wrote: > Hi Tim, > > maybe moving the xoai.xml to config/ as it already contains many xml > configuration files. > > On 24 September 2012 17:10, Tim Donohue <[email protected] > <mailto:[email protected]>> wrote: > > Hi João, > > Although it may not be "ideal", I'd be OK with the xoai.xml file > just moving over to /config/crosswalks/oai/ as well. It looks like > the xoai.xml file actually configures which crosswalks are enabled & > sets up the various crosswalks/metadata formats. So, it seems > reasonable enough to just leave it in the "oai" directory alongside > the crosswalks and move everything over to /config/crosswalks/oai/ > > Unless someone has better ideas? > > - Tim > > > On Monday, September 24, 2012 10:54:47 AM, João Melo wrote: > > Hi, > > moving the XOAI XSLs to config/crosswalks seems fine. > So there is only one file left to pack up - > config/modules/oai/xoai.xml: > > https://github.com/DSpace/__DSpace/tree/master/dspace/__config/modules/oai > > <https://github.com/DSpace/DSpace/tree/master/dspace/config/modules/oai> > It's the XOAI core library configuration file. > > On 24 September 2012 16:14, Tim Donohue <[email protected] > <mailto:[email protected]> > <mailto:[email protected] > <mailto:[email protected]>__>> wrote: > > Robin, > > Good point about the config/crosswalks area. It does look > like the > current config/modules/oai/ directory really just consists > of various > XSLT "crosswalks" to support various OAI output formats. > > So, I can see the point of perhaps moving it over to > config/crosswalks/oai/ I'd agree that actually seems like > a more > appropriate place than config/oai or config/modules/oai. > > I also agree that the > "config/crosswalks/oaidc.__properties" file now > looks obsolete (looks to be replaced by > oai/metadataFormats/oai_dc.__xsl). > > - Tim > > On 9/24/2012 9:49 AM, Robin Taylor wrote: > > Hi Tim, > > > > Looks like neither option is perfect but I think I would side > with Mark > > at the moment. All the files in config/modules are Java > property > files > > and are read by ConfigurationManager or ConfigurationService, > the new > > files are xslt files. I'm not too sure what is the best > home for > them > > but perhaps config/crosswalks ? Actually, I notice there > is an > old file > > oaidc.properties in there, is that now redundant ? > > > > Cheers. > > > > > > On 24/09/12 14:54, Tim Donohue wrote: > >> Hi Mark, > >> > >> Why do you feel that directory should be moved? > >> > >> If you notice, the main OAI config file is at: > >> > > https://github.com/DSpace/__DSpace/blob/master/dspace/__config/modules/oai.cfg > > <https://github.com/DSpace/DSpace/blob/master/dspace/config/modules/oai.cfg> > >> > >> Having the "/oai" config directory under > /config/modules/oai/ > puts it at > >> the same level as this "oai.cfg" file (which uses the oai/ > >> subdirectory). This also makes it slightly easier to > find all the > >> configs related to the new XOAI as they are all next to > each other. > >> > >> I'd actually worry that moving it up a level would cause > additional > >> confusion...as then you'd have OAI configs at several > levels: > >> > >> /config/modules/oai.cfg > >> /config/oai/* > >> > >> That being said, if others agree this is a misuse of the > >> 'config/modules/' directory then I'm OK with moving it > (would > need to > >> update the docs obviously). Just wanted to point out the > reasoning why > >> it seems logical to keep the XOAI config directory at > /config/modules/oai/ > >> > >> - Tim > >> > >> On 9/22/2012 12:28 AM, Mark Diggory wrote: > >>> Lyncode and other XOAI Developers, > >>> > >>> The config/modules directory is meant to hold > dspace.cfg submodule > >>> configuration files only. I would recommend you please > move the > >>> following directory out of the config/modules directory: > >>> > >>> > > https://github.com/DSpace/__DSpace/tree/master/dspace/__config/modules/oai > > <https://github.com/DSpace/DSpace/tree/master/dspace/config/modules/oai> > >>> > >>> I'd recommend it would be better if this was placed > into the > directory > >>> called. > >>> > >>> > https://github.com/DSpace/__DSpace/tree/master/dspace/__config/oai > <https://github.com/DSpace/DSpace/tree/master/dspace/config/oai> > >>> > >>> Regards, > >>> Mark > >>> > >>> -- > >>> @mire Inc. > >>> *Mark Diggory *(Schedule a Meeting > <http://doodle.com/mdiggory>) > >>> /2888 Loker Avenue East, Suite 315, Carlsbad, CA. 92010/ > >>> /Esperantolaan 4, Heverlee 3001, Belgium/ > >>> http://www.atmire.com <http://www.atmire.com/> > >>> > >>> > >>> > >>> > >>> > > > ------------------------------__------------------------------__------------------ > >>> How fast is your code? > >>> 3 out of 4 devs don\\\'t know how their code performs in > production. > >>> Find out how slow your code is with AppDynamics Lite. > >>> http://ad.doubleclick.net/clk;__262219672;13503038;z > <http://ad.doubleclick.net/clk;262219672;13503038;z>? > >>> > http://info.appdynamics.com/__FreeJavaPerformanceDownload.__html > <http://info.appdynamics.com/FreeJavaPerformanceDownload.html> > >>> > >>> > >>> > >>> _________________________________________________ > >>> Dspace-devel mailing list > >>> Dspace-devel@lists.__sourceforge.net > <mailto:[email protected]> > <mailto:Dspace-devel@lists.__sourceforge.net > <mailto:[email protected]>> > > >>> > https://lists.sourceforge.net/__lists/listinfo/dspace-devel > <https://lists.sourceforge.net/lists/listinfo/dspace-devel> > >>> > >> > > > ------------------------------__------------------------------__------------------ > >> Live Security Virtual Conference > >> Exclusive live event will cover all the ways today's > security and > >> threat landscape has changed and how IT managers can > respond. > Discussions > >> will include endpoint security, mobile security and the > latest > in malware > >> threats. > http://www.accelacomm.com/jaw/__sfrnl04242012/114/50122263/ > <http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/> > >> _________________________________________________ > >> Dspace-devel mailing list > >> Dspace-devel@lists.__sourceforge.net > <mailto:[email protected]> > <mailto:Dspace-devel@lists.__sourceforge.net > <mailto:[email protected]>> > > >> > https://lists.sourceforge.net/__lists/listinfo/dspace-devel > <https://lists.sourceforge.net/lists/listinfo/dspace-devel> > > > > > > > > ------------------------------__------------------------------__------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's > security and > threat landscape has changed and how IT managers can respond. > Discussions > will include endpoint security, mobile security and the > latest in > malware > threats. > http://www.accelacomm.com/jaw/__sfrnl04242012/114/50122263/ > <http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/> > _________________________________________________ > Dspace-devel mailing list > Dspace-devel@lists.__sourceforge.net > <mailto:[email protected]> > <mailto:Dspace-devel@lists.__sourceforge.net > <mailto:[email protected]>> > https://lists.sourceforge.net/__lists/listinfo/dspace-devel > <https://lists.sourceforge.net/lists/listinfo/dspace-devel> > > > > > -- > > Thanks, João Melo (My Portfolio > <http://www.lyncode.com/m/__jmelo/ > <http://www.lyncode.com/m/jmelo/>>) > DSpace Department > *Lyncode*: Official website > > <http://www.google.com/url?q=__http%3A%2F%2Fwww.lyncode.com%__2F&sa=D&sntz=1&usg=__AFrqEzdV8iS6rMxflxnn138XReuRfU__G3OQ > > <http://www.google.com/url?q=http%3A%2F%2Fwww.lyncode.com%2F&sa=D&sntz=1&usg=AFrqEzdV8iS6rMxflxnn138XReuRfUG3OQ>> > > Follow us on Facebook > > <http://www.google.com/url?q=__http%3A%2F%2Ftwitter.com%__2Flyncode&sa=D&sntz=1&usg=__AFrqEzeDuT3ZqMW5uVIA8AoxtTtAei__CX3Q > > <http://www.google.com/url?q=http%3A%2F%2Ftwitter.com%2Flyncode&sa=D&sntz=1&usg=AFrqEzeDuT3ZqMW5uVIA8AoxtTtAeiCX3Q>> > > <http://www.google.com/url?q=__http%3A%2F%2Fwww.facebook.com%__2Flyncode&sa=D&sntz=1&usg=__AFrqEzcWXjHa3gKBGLsNVxktapxkiW__Dnww > > <http://www.google.com/url?q=http%3A%2F%2Fwww.facebook.com%2Flyncode&sa=D&sntz=1&usg=AFrqEzcWXjHa3gKBGLsNVxktapxkiWDnww>> > > > > > > -- > > Thanks, João Melo (My Portfolio <http://www.lyncode.com/m/jmelo/>) > DSpace Department > *Lyncode*: Official website > <http://www.google.com/url?q=http%3A%2F%2Fwww.lyncode.com%2F&sa=D&sntz=1&usg=AFrqEzdV8iS6rMxflxnn138XReuRfUG3OQ> > > Follow us on Facebook > <http://www.google.com/url?q=http%3A%2F%2Ftwitter.com%2Flyncode&sa=D&sntz=1&usg=AFrqEzeDuT3ZqMW5uVIA8AoxtTtAeiCX3Q> > <http://www.google.com/url?q=http%3A%2F%2Fwww.facebook.com%2Flyncode&sa=D&sntz=1&usg=AFrqEzcWXjHa3gKBGLsNVxktapxkiWDnww> > > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Dspace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-devel
