Agreed on all these points. Especially since the config/modules directory is
traversed programmatically, and the level up from there seems not perfect.
--
sands fish
Senior Software Engineer
MIT Libraries
Technology Research & Development
[email protected]<mailto:[email protected]>
E25-131
On Sep 24, 2012, at 11:14 AM, Tim Donohue wrote:
Robin,
Good point about the config/crosswalks area. It does look like the
current config/modules/oai/ directory really just consists of various
XSLT "crosswalks" to support various OAI output formats.
So, I can see the point of perhaps moving it over to
config/crosswalks/oai/ I'd agree that actually seems like a more
appropriate place than config/oai or config/modules/oai.
I also agree that the "config/crosswalks/oaidc.properties" file now
looks obsolete (looks to be replaced by oai/metadataFormats/oai_dc.xsl).
- Tim
On 9/24/2012 9:49 AM, Robin Taylor wrote:
Hi Tim,
Looks like neither option is perfect but I think I would side with Mark
at the moment. All the files in config/modules are Java property files
and are read by ConfigurationManager or ConfigurationService, the new
files are xslt files. I'm not too sure what is the best home for them
but perhaps config/crosswalks ? Actually, I notice there is an old file
oaidc.properties in there, is that now redundant ?
Cheers.
On 24/09/12 14:54, Tim Donohue wrote:
Hi Mark,
Why do you feel that directory should be moved?
If you notice, the main OAI config file is at:
https://github.com/DSpace/DSpace/blob/master/dspace/config/modules/oai.cfg
Having the "/oai" config directory under /config/modules/oai/ puts it at
the same level as this "oai.cfg" file (which uses the oai/
subdirectory). This also makes it slightly easier to find all the
configs related to the new XOAI as they are all next to each other.
I'd actually worry that moving it up a level would cause additional
confusion...as then you'd have OAI configs at several levels:
/config/modules/oai.cfg
/config/oai/*
That being said, if others agree this is a misuse of the
'config/modules/' directory then I'm OK with moving it (would need to
update the docs obviously). Just wanted to point out the reasoning why
it seems logical to keep the XOAI config directory at /config/modules/oai/
- Tim
On 9/22/2012 12:28 AM, Mark Diggory wrote:
Lyncode and other XOAI Developers,
The config/modules directory is meant to hold dspace.cfg submodule
configuration files only. I would recommend you please move the
following directory out of the config/modules directory:
https://github.com/DSpace/DSpace/tree/master/dspace/config/modules/oai
I'd recommend it would be better if this was placed into the directory
called.
https://github.com/DSpace/DSpace/tree/master/dspace/config/oai
Regards,
Mark
--
@mire Inc.
*Mark Diggory *(Schedule a Meeting <http://doodle.com/mdiggory>)
/2888 Loker Avenue East, Suite 315, Carlsbad, CA. 92010/
/Esperantolaan 4, Heverlee 3001, Belgium/
http://www.atmire.com <http://www.atmire.com/>
------------------------------------------------------------------------------
How fast is your code?
3 out of 4 devs don\\\'t know how their code performs in production.
Find out how slow your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219672;13503038;z?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
Dspace-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/dspace-devel
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/dspace-devel
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/dspace-devel
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
