Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] dt-bindings: display: solomon,ssd16xx: commit message and schema mismatch for ssd1677 --
commit 0557e7fb08a4970f824714f1d57d93f2cdcd0204 Author: Devarsh Thakkar <[email protected]> dt-bindings: display: solomon,ssd16xx: Add Solomon SSD1677 controller Adds support for the Solomon SSD1677 controller to the solomon,ssd16xx binding. The commit message indicates adding it to the controller fallback enum, but the schema restructuring implements it as a standalone constant. > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd16xx.yaml > b/Documentation/devicetree/bindings/display/solomon,ssd16xx.yaml > index b31fb862de042..1a94ad9b0d944 100644 > --- a/Documentation/devicetree/bindings/display/solomon,ssd16xx.yaml > +++ b/Documentation/devicetree/bindings/display/solomon,ssd16xx.yaml > @@ -24,12 +24,13 @@ allOf: > > properties: > compatible: > - items: > - - enum: > - # Good Display 4.2" 400x300 monochrome e-ink panel > - - gooddisplay,gdey042t81 > - - enum: > - - solomon,ssd1683 > + oneOf: > + - items: > + - enum: > + # Good Display 4.2" 400x300 monochrome e-ink panel > + - gooddisplay,gdey042t81 > + - const: solomon,ssd1683 > + - const: solomon,ssd1677 [Severity: Medium] The commit message explicitly states the intent to "Add solomon,ssd1677 to the controller fallback compatible enum." However, the patch implements it as a standalone const under a new oneOf block. In dt-schema, a bare const validates an array containing exactly one element. While restructuring the schema to avoid falsely linking the new ssd1677 controller with the existing ssd1683-based panel is structurally correct, this creates a mismatch between the commit message's stated intent and the implemented schema constraints. Developers attempting to use the compatible string as a fallback (as advertised in the commit message) like: compatible = "vendor,panel", "solomon,ssd1677"; will encounter dt-schema validation failures during make dtbs_check. Can the commit message be updated to reflect the standalone nature of this new compatible, or does the schema need to permit fallback usage? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
