Amit Barzilai <[email protected]> writes: Hello Amit,
> On Thu, Sep 10, 2026 at 2:16 PM Javier Martinez Canillas > <[email protected]> wrote: >> >> [email protected] writes: >> >> >> +allOf: >> >> + - $ref: solomon,ssd-common.yaml# >> >> + >> >> +properties: >> >> + compatible: >> >> + enum: >> >> + - solomon,ssd1351 >> > >> > [Severity: Low] >> > Should this properties block also declare default values for solomon,width >> > and solomon,height? >> > >> > Other bindings that include solomon,ssd-common.yaml, such as >> > solomon,ssd133x.yaml, establish default geometry values for their specific >> > compatible strings in this block. Without these default values, device >> > trees >> > that omit the width and height properties will lack a schema-defined >> > default >> > geometry. >> > >> > -- >> > Sashiko AI review · >> > https://sashiko.dev/#/patchset/[email protected]?part=1 >> > >> >> I think Sashiko is correct here. Let's include the default values in the >> DT binding schema to be consistent to what is done in the other bindings. > > I included them in v1, Krzysztof mentioned that they should be removed > since they are deducible from the compatible: > https://lore.kernel.org/dri-devel/20260611-psychedelic-funky-foxhound-a8e39d@quoll/ > > I personally agree with Krzysztof, but I won't die on this hill. > Let me know which way you'd like this to go. > I see. I don't have a strong opinion either so I'm OK with not having it in the binding doc then. > -- > Thanks, > Amit > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
