[email protected] writes: >> +allOf: >> + - $ref: solomon,ssd-common.yaml# >> + >> +properties: >> + compatible: >> + enum: >> + - solomon,ssd1351 > > [Severity: Low] > Should this properties block also declare default values for solomon,width > and solomon,height? > > Other bindings that include solomon,ssd-common.yaml, such as > solomon,ssd133x.yaml, establish default geometry values for their specific > compatible strings in this block. Without these default values, device trees > that omit the width and height properties will lack a schema-defined default > geometry. > > -- > Sashiko AI review ยท > https://sashiko.dev/#/patchset/[email protected]?part=1 >
I think Sashiko is correct here. Let's include the default values in the DT binding schema to be consistent to what is done in the other bindings. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
