On Wed, Jul 08, 2026 at 11:56:44AM +0200, Jiri Slaby (SUSE) wrote:
> irq_domain_add_linear() is going away as being obsolete now. Switch to
> the preferred irq_domain_create_linear(). That differs in the first
> parameter: It takes more generic struct fwnode_handle instead of struct
> device_node. Therefore, of_fwnode_handle() is added around the
> parameter.
>
> Note some of the users can likely use dev->fwnode directly instead of
> indirect of_fwnode_handle(dev->of_node). But dev->fwnode is not
> guaranteed to be set for all, so this has to be investigated on case to
> case basis (by people who can actually test with the HW).
>
> Signed-off-by: Jiri Slaby (SUSE) <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Liu Ying <[email protected]>
> ---
> Cc: Maarten Lankhorst <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: Thomas Zimmermann <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Simona Vetter <[email protected]>
> Cc: Frank Li <[email protected]>
> Cc: Sascha Hauer <[email protected]>
> Cc: Pengutronix Kernel Team <[email protected]>
> Cc: Fabio Estevam <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> drivers/gpu/drm/imx/dc/dc-ic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imx/dc/dc-ic.c b/drivers/gpu/drm/imx/dc/dc-ic.c
> index a270ae4030cd..d8aa46ee6a7a 100644
> --- a/drivers/gpu/drm/imx/dc/dc-ic.c
> +++ b/drivers/gpu/drm/imx/dc/dc-ic.c
> @@ -174,7 +174,7 @@ static int dc_ic_probe(struct platform_device *pdev)
> regmap_write(data->regs, USERINTERRUPTMASK(i), 0xffffffff);
> }
>
> - data->domain = irq_domain_add_linear(dev->of_node, IRQ_COUNT,
> + data->domain = irq_domain_create_linear(of_fwnode_handle(dev->of_node),
> IRQ_COUNT,
> &irq_generic_chip_ops, data);
'./scripts/checkpatch.pl --strict' complaints:
CHECK: Alignment should match open parenthesis
#34: FILE: drivers/gpu/drm/imx/dc/dc-ic.c:178:
+ data->domain = irq_domain_create_linear(of_fwnode_handle(dev->of_node),
IRQ_COUNT,
&irq_generic_chip_ops, data);
Acked-by: Liu Ying <[email protected]>
> if (!data->domain) {
> dev_err(dev, "failed to create IRQ domain\n");
> --
> 2.55.0
>
--
Regards,
Liu Ying
