sparse (build with C=1) warns: drivers/gpu/drm/imx/dc/dc-ic.c:273:24: warning: symbol 'dc_ic_driver' was not declared. Should it be static?
And it is right. Include dc-drv.h which declares the struct. This ensures the types of both match. Signed-off-by: Jiri Slaby (SUSE) <[email protected]> Cc: Liu Ying <[email protected]> --- Cc: Maarten Lankhorst <[email protected]> Cc: Maxime Ripard <[email protected]> Cc: Thomas Zimmermann <[email protected]> Cc: David Airlie <[email protected]> Cc: Simona Vetter <[email protected]> Cc: Frank Li <[email protected]> Cc: Sascha Hauer <[email protected]> Cc: Pengutronix Kernel Team <[email protected]> Cc: Fabio Estevam <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] --- drivers/gpu/drm/imx/dc/dc-ic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/imx/dc/dc-ic.c b/drivers/gpu/drm/imx/dc/dc-ic.c index d8aa46ee6a7a..0f2fc7aecf31 100644 --- a/drivers/gpu/drm/imx/dc/dc-ic.c +++ b/drivers/gpu/drm/imx/dc/dc-ic.c @@ -14,6 +14,8 @@ #include <linux/pm_runtime.h> #include <linux/regmap.h> +#include "dc-drv.h" + #define USERINTERRUPTMASK(n) (0x8 + 4 * (n)) #define INTERRUPTENABLE(n) (0x10 + 4 * (n)) #define INTERRUPTPRESET(n) (0x18 + 4 * (n)) -- 2.55.0
