Am Montag, 25. August 2025, 10:28:40 Mitteleuropäische Sommerzeit schrieb Nicolas Frattaroli: > The era of hand-rolled HIWORD_UPDATE macros is over, at least for those > drivers that use constant masks. > > The Rockchip PCIe PHY driver, used on the RK3399, has its own definition > of HIWORD_UPDATE. > > Remove it, and replace instances of it with hw_bitfield.h's > FIELD_PREP_WM16. To achieve this, some mask defines are reshuffled, as > FIELD_PREP_WM16 uses the mask as both the mask of bits to write and to > derive the shift amount from in order to shift the value. > > In order to ensure that the mask is always a constant, the inst->index > shift is performed after the FIELD_PREP_WM16, as this is a runtime > value. > > From this, we gain compile-time error checking, and in my humble opinion > nicer code, as well as a single definition of this macro across the > entire codebase to aid in code comprehension. > > Tested on a RK3399 ROCKPro64, where PCIe still works as expected when > accessing an NVMe drive. > > Signed-off-by: Nicolas Frattaroli <nicolas.frattar...@collabora.com>
Reviewed-by: Heiko Stuebner <he...@sntech.de>
