On Mon, 25 Aug 2025 10:28:35 +0200 Nicolas Frattaroli wrote: > The era of hand-rolled HIWORD_UPDATE macros is over, at least for those > drivers that use constant masks. > > Like many other Rockchip drivers, dwmac-rk has its own HIWORD_UPDATE > macro. Its semantics allow us to redefine it as a wrapper to the shared > hw_bitfield.h FIELD_PREP_WM16 macros though. > > Replace the implementation of this driver's very own HIWORD_UPDATE macro > with an instance of FIELD_PREP_WM16 from hw_bitfield.h. This keeps the > diff easily reviewable, while giving us more compile-time error > checking. > > The related GRF_BIT macro is left alone for now; any attempt to rework > the code to not use its own solution here would likely end up harder to > review and less pretty for the time being.
Acked-by: Jakub Kicinski <k...@kernel.org>
