Am Montag, 25. August 2025, 10:28:32 Mitteleuropäische Sommerzeit schrieb Nicolas Frattaroli: > The era of hand-rolled HIWORD_UPDATE macros is over, at least for those > drivers that use constant masks. > > Remove this driver's HIWORD_UPDATE macro, and replace all instances of > it with (hopefully) equivalent FIELD_PREP_WM16 instances. To do this, a > few of the defines are being adjusted, as FIELD_PREP_WM16 shifts up the > value for us. This gets rid of the icky update(mask, mask) shenanigans. > > The benefit of using FIELD_PREP_WM16 is that it does more checking of > the input, hopefully catching errors. In practice, a shared definition > makes code more readable than several different flavours of the same > macro, and the shifted value helps as well. > > I do not have the hardware that uses this particular driver, so it's > compile-tested only as far as my own testing goes. > > Signed-off-by: Nicolas Frattaroli <nicolas.frattar...@collabora.com>
Reviewed-by: Heiko Stuebner <he...@sntech.de>
