On Wed, Aug 20, 2025 at 05:14:47PM +0800, Jinchao Wang wrote:
> This patch updates the fbcon_skip_panic() function to use
> the panic_in_progress() helper.
>
> The previous direct access to panic_cpu is less
> readable and is being replaced by a dedicated function
> that more clearly expresses the intent.
>
> This change is part of a series to refactor the kernel's
> panic handling logic for better clarity and robustness.
>
> Signed-off-by: Jinchao Wang <wangjinchao...@gmail.com>
> ---
> drivers/video/fbdev/core/fbcon.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c
> b/drivers/video/fbdev/core/fbcon.c
> index 55f5731e94c3..b062b05f4128 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -279,14 +279,7 @@ static int fbcon_get_rotate(struct fb_info *info)
>
> static bool fbcon_skip_panic(struct fb_info *info)
> {
> -/* panic_cpu is not exported, and can't be used if built as module. Use
> - * oops_in_progress instead, but non-fatal oops won't be printed.
> - */
> -#if defined(MODULE)
> - return (info->skip_panic && unlikely(oops_in_progress));
> -#else
> - return (info->skip_panic && unlikely(atomic_read(&panic_cpu) !=
> PANIC_CPU_INVALID));
> -#endif
> + return (info->skip_panic && unlikely(panic_in_progress()));
> }
>
> static inline bool fbcon_is_active(struct vc_data *vc, struct fb_info *info)
> --
> 2.43.0
Acked-by Qianqiang Liu <qianqiang....@163.com>
--
Best,
Qianqiang Liu
