In the error path where ret < 0, the ternary operator "ret < 0 ? ret : -EIO" will always evaluate to ret since ret is guaranteed to be negative. Simplify by directly returning ret.
Found by Coverity(CID 1649044). Signed-off-by: Nai-Chen Cheng <bleach1...@gmail.com> --- drivers/gpu/drm/display/drm_dp_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index 1ecc3df7e3167d13636e194c4aab44ee8979aa11..654d466183d5ccdefcb4029dc4efc199f3b7b6ff 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -4227,7 +4227,7 @@ drm_edp_backlight_probe_state(struct drm_dp_aux *aux, struct drm_edp_backlight_i if (ret < 0) { drm_dbg_kms(aux->drm_dev, "%s: Failed to read backlight mode: %d\n", aux->name, ret); - return ret < 0 ? ret : -EIO; + return ret; } *current_mode = (mode_reg & DP_EDP_BACKLIGHT_CONTROL_MODE_MASK); --- base-commit: b19a97d57c15643494ac8bfaaa35e3ee472d41da change-id: 20250820-drm-dp-helper-logically-dead-code-2-428c853deb95 Best regards, -- Nai-Chen Cheng <bleach1...@gmail.com>