On Thu Aug 7, 2025 at 6:43 PM CEST, Himal Prasad Ghimiray wrote: > This change adds support for passing flags to drm_gpuvm_sm_map() and > sm_map_ops_create(), enabling future extensions that affect split/merge > logic in drm_gpuvm. > > v2 > - Move flag to drm_gpuvm_map_req > > Cc: Danilo Krummrich <d...@kernel.org> > Cc: Boris Brezillon <bbrezil...@kernel.org> > Cc: Caterina Shablia <caterina.shab...@collabora.com> > Cc: Matthew Brost <matthew.br...@intel.com> > Cc: <dri-devel@lists.freedesktop.org> > Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimi...@intel.com> > --- > include/drm/drm_gpuvm.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h > index cbb9b6519462..116f77abd570 100644 > --- a/include/drm/drm_gpuvm.h > +++ b/include/drm/drm_gpuvm.h > @@ -1049,6 +1049,13 @@ struct drm_gpuva_ops { > */ > #define drm_gpuva_next_op(op) list_next_entry(op, entry) > > +enum drm_gpuvm_sm_map_ops_flags {
Please also add a doc-comment for the enum type itself, explaing where those flags are used, etc. > + /** > + * %DRM_GPUVM_SM_MAP_OPS_FLAG_NONE: DEFAULT sm_map ops Shouldn't this be '@DRM_GPUVM_SM_MAP_OPS_FLAG_NONE:'? > + */ > + DRM_GPUVM_SM_MAP_OPS_FLAG_NONE = 0, > +};