On Fri, May 30, 2025 at 12:23:51AM GMT, Michal Wilczynski wrote: > Update the img,powervr-rogue.yaml device tree bindings to include the > T-HEAD TH1520 SoC's specific GPU compatible string. > > The thead,th1520-gpu compatible, along with its full chain > img,img-bxm-4-64, and img,img-rogue, is added to the > list of recognized GPU types. This allows the Imagination DRM driver > to correctly bind to the GPU node defined in the TH1520 device tree.
If there is going to be any new version: Last sentence feels redundant or obvious. That's the point of DT anyway, so not need to state that. I suggest dropping it or replacing with some hardware description. A nit, subject: drop second/last, redundant "to Imagination bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Use proper prefix, so: dt-bindings: gpu: img,powervr-rogue: Add foo bar > > The power-domains property requirement for img,img-bxm-4-64 is also > ensured by adding it to the relevant allOf condition. > > Signed-off-by: Michal Wilczynski <m.wilczyn...@samsung.com> > --- > Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > index > 4450e2e73b3ccf74d29f0e31e2e6687d7cbe5d65..c12837a0d39b8c3043b9133d444cc33a59135c33 > 100644 > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > @@ -26,6 +26,11 @@ properties: > - ti,j721s2-gpu > - const: img,img-bxs-4-64 > - const: img,img-rogue > + - items: > + - enum: > + - thead,th1520-gpu > + - const: img,img-bxm-4-64 We keep ordering by fallbacks, so this should go above items with img,img-bxs-4-64 fallback (m < s). Acked-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org> Best regards, Krzysztof
