Hello Liu, On Tue, 29 Apr 2025 10:19:27 +0800 Liu Ying <victor....@nxp.com> wrote:
[...] > > diff --git a/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c > > b/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c > > index > > f072c6ed39ef183b10518b43bd6d979bc89e36f9..8069c4881e9058f5462f99116799b589bd52b19e > > 100644 > > --- a/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c > > +++ b/drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c > > @@ -59,9 +59,10 @@ struct drm_bridge *devm_imx_drm_legacy_bridge(struct > > device *dev, > > struct imx_legacy_bridge *imx_bridge; > > int ret; > > > > - imx_bridge = devm_kzalloc(dev, sizeof(*imx_bridge), GFP_KERNEL); > > - if (!imx_bridge) > > - return ERR_PTR(-ENOMEM); > > + imx_bridge = devm_drm_bridge_alloc(dev, struct imx_legacy_bridge, > > + base, &imx_legacy_bridge_funcs); > > + if (IS_ERR(imx_bridge)) > > + return PTR_ERR(imx_bridge); > > > > ret = of_get_drm_display_mode(np, > > &imx_bridge->mode, > > @@ -71,8 +72,6 @@ struct drm_bridge *devm_imx_drm_legacy_bridge(struct > > device *dev, > > return ERR_PTR(ret); > > > > imx_bridge->mode.type |= DRM_MODE_TYPE_DRIVER; > > - > > Nit: Can you please leave this blank line undeleted? And I see similar > situations where lines are unnecessarily deleted by this patch, so this > applies > to the entire patch. I agree some empty lines removals are not nice in this patch. However I have no idea how to avoid that with spatch, so I'd have to redo [a part of] the changes manually to avoid it. :-( Anyway, those I spotted look quite innocuous. So I'll assume it is "OK enough" as is, unless there are strong requests to do differently. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
