On 4/21/25 10:18 PM, Barnabás Czémán wrote:
> From: Dang Huynh <danc...@riseup.net>
>
> Add initial support for MSM8937 SoC.
>
> Signed-off-by: Dang Huynh <danc...@riseup.net>
> Co-developed-by: Barnabás Czémán <barnabas.cze...@mainlining.org>
> Signed-off-by: Barnabás Czémán <barnabas.cze...@mainlining.org>
> ---
[...]
> + tsens_base1: base1@1d8 {
> + reg = <0x1d8 1>;
The size part should be hex too
[...]
> + wcss-wlan2-pins {
> + pins = "gpio76";
> + function = "wcss_wlan2";
> + drive-strength = <6>;
> + bias-pull-up;
> +
> + };
> +
> + };
random newline /\
[...]
> + mdss: display-subsystem@1a00000 {
> + compatible = "qcom,mdss";
> + reg = <0x01a00000 0x1000>,
> + <0x01ab0000 0x1040>;
The latter region is 0x3000-long
> + reg-names = "mdss_phys", "vbif_phys";
Please make reg-names a vertical list too
[...]
> + gpu: gpu@1c00000 {
> + compatible = "qcom,adreno-505.0", "qcom,adreno";
> + reg = <0x1c00000 0x40000>;
Please pad the address part to 8 hex digits
[...]
> + gpu_opp_table: opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-19200000 {
> + opp-hz = /bits/ 64 <19200000>;
> + opp-supported-hw = <0xff>;
The comment from the previous revision still stands
Konrad
