Reviewed-by: Alyssa Rosenzweig <aly...@rosenzweig.io>
Le Wed , Apr 16, 2025 at 10:25:30PM +0200, Janne Grunau via B4 Relay a écrit :
> From: Janne Grunau <j...@jannau.net>
>
> Interrupt handlers run with interrupts disabled so it is not necessary
> to protect them against reentrancy.
>
> Signed-off-by: Janne Grunau <j...@jannau.net>
> ---
> drivers/gpu/drm/adp/adp_drv.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/adp/adp_drv.c b/drivers/gpu/drm/adp/adp_drv.c
> index
> c6238fb059342eebafddd53650a499fea0079dea..abb42f57fe5984a8f0f4be7081fb6803866b5d5b
> 100644
> --- a/drivers/gpu/drm/adp/adp_drv.c
> +++ b/drivers/gpu/drm/adp/adp_drv.c
> @@ -121,7 +121,6 @@ struct adp_drv_private {
> dma_addr_t mask_iova;
> int be_irq;
> int fe_irq;
> - spinlock_t irq_lock;
> struct drm_pending_vblank_event *event;
> };
>
> @@ -488,8 +487,6 @@ static irqreturn_t adp_fe_irq(int irq, void *arg)
> u32 int_status;
> u32 int_ctl;
>
> - spin_lock(&adp->irq_lock);
> -
> int_status = readl(adp->fe + ADP_INT_STATUS);
> if (int_status & ADP_INT_STATUS_VBLANK) {
> drm_crtc_handle_vblank(&adp->crtc);
> @@ -507,7 +504,6 @@ static irqreturn_t adp_fe_irq(int irq, void *arg)
>
> writel(int_status, adp->fe + ADP_INT_STATUS);
>
> - spin_unlock(&adp->irq_lock);
>
> return IRQ_HANDLED;
> }
> @@ -572,8 +568,6 @@ static int adp_probe(struct platform_device *pdev)
> if (IS_ERR(adp))
> return PTR_ERR(adp);
>
> - spin_lock_init(&adp->irq_lock);
> -
> dev_set_drvdata(&pdev->dev, &adp->drm);
>
> err = adp_parse_of(pdev, adp);
>
> --
> 2.49.0
>
>
