> -----Original Message----- > From: Krzysztof Kozlowski <k...@kernel.org> > Sent: 2024年11月21日 16:23 > To: Keith Zhao <keith.z...@starfivetech.com> > Cc: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > andrzej.ha...@intel.com; neil.armstr...@linaro.org; rf...@kernel.org; > laurent.pinch...@ideasonboard.com; jo...@kwiboo.se; > jernej.skra...@gmail.com; maarten.lankho...@linux.intel.com; > mrip...@kernel.org; tzimmerm...@suse.de; airl...@gmail.com; > sim...@ffwll.ch; r...@kernel.org; krzk...@kernel.org; conor...@kernel.org; > h...@rock-chips.com; he...@sntech.de; andy....@rock-chips.com; William Qiu > <william....@starfivetech.com>; Xingyu Wu <xingyu...@starfivetech.com>; > ker...@esmil.dk; paul.walms...@sifive.com; pal...@dabbelt.com; > a...@eecs.berkeley.edu; p.za...@pengutronix.de; Changhuang Liang > <changhuang.li...@starfivetech.com>; Jack Zhu <jack....@starfivetech.com>; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH v5 1/9] dt-bindings: display: bindings for starfive,JH7110 > display pipeline > > On Wed, Nov 20, 2024 at 02:18:40PM +0800, keith zhao wrote: > > - Added bindings to support the display subsystem on the JH7110 SoC. > > Please do not use "This commit/patch/change" (implied) and past tense, but > imperative mood. See longer explanation here: > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitti > ng-patches.rst#L95 > > > > > - Included the DC8200 display controller and Inno HDMI controller. > > > > - Created innosilicon,inno-hdmi.yaml schema containing common properties > > for the Inno DesignWare HDMI TX controller. > > This isn't a full device tree binding specification, > > but is intended to be referenced by platform-specific bindings > > for the IP core. > > > > Signed-off-by: keith zhao <keith.z...@starfivetech.com> > > --- > > .../display/bridge/innosilicon,inno-hdmi.yaml | 45 +++++ > > .../display/rockchip/rockchip,inno-hdmi.yaml | 27 +-- > > .../starfive/starfive,jh7110-dc8200.yaml | 176 ++++++++++++++++++ > > .../starfive/starfive,jh7110-inno-hdmi.yaml | 91 +++++++++ > > .../soc/starfive/starfive,jh7110-syscon.yaml | 1 + > > I do not see how you addressed my feedback. I asked you to split the patch. > Where is the split?
Oh sorry, I had a bit of a misunderstanding here before. "Your patch is difficult to review. Split changing existing bindings (and defining common part) to a separate patch." ...... Split changing existing bindings (and defining common part) to a separate "bindings". ....... > > Your answer to my request to split was "Background is ...", yeah, so what? You > are not going to split? > Based on the misunderstanding of this idea, it led to not splitting the patch this time. Now I understand. Will split it . > > > MAINTAINERS | 8 + > > 6 files changed, 323 insertions(+), 25 deletions(-) create mode > > 100644 > > Documentation/devicetree/bindings/display/bridge/innosilicon,inno-hdmi > > .yaml create mode 100644 > > Documentation/devicetree/bindings/display/starfive/starfive,jh7110-dc8 > > 200.yaml create mode 100644 > > Documentation/devicetree/bindings/display/starfive/starfive,jh7110-inn > > o-hdmi.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/innosilicon,inno-hd > > mi.yaml > > b/Documentation/devicetree/bindings/display/bridge/innosilicon,inno-hd > > mi.yaml > > new file mode 100644 > > index 000000000000..f2543aebc312 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/innosilicon,inn > > +++ o-hdmi.yaml > > @@ -0,0 +1,45 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +http://devicetree.org/schemas/display/bridge/innosilicon,inno-hdmi.ya > > +ml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Common Properties for Innosilicon HDMI TX IP > > + > > +maintainers: > > + - keith zhao <keith.z...@starfivetech.com> > > + > > +description: | > > Do not need '|' unless you need to preserve formatting. > I will remove the '|' since it's not necessary for preserving formatting. And here is the reason why add '|' before. https://elixir.bootlin.com/linux/v6.12/source/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml#L12 > > > > + Innosilicon HDMI TX is an HDMI transmission device integrated into the > zap SoC. > > Keep and extend. Ok > > > + This document specifies the device tree properties for the INNO HDMI IP > core. > > Keep... but what is INNO HDMI IP core? Another name? Different block? > > > > + It is intended to be referenced by platform-specific device tree > > + bindings, which will determine the necessity of each property. > > Not much improved here. Last two sentences are almost useless. Again - > document the hardware. Drop this sentence. > > I already complained about this. I already complained that you keep ignoring > my > comments and this does not improve much. > > Since you did not implement my main feedback I am going to NAK the rest > except one more thing: I appreciate your patience, I will not refer to the existing YAML files in the main branch for writing anymore; I will only follow your suggestions https://elixir.bootlin.com/linux/v6.12/source/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml#L18 > > ... > > > + > > +properties: > > + compatible: > > + const: "starfive,jh7110-inno-hdmi" > > I could not be more specific in my previous feedback. Improvements? No. > Stop wasting our time. > This modification was overlooked when merging, sorry again. Thank you for your feedback. > NAK. > > Best regards, > Krzysztof
