> -----Original Message-----
> From: Krzysztof Kozlowski <k...@kernel.org>
> Sent: 2024年11月20日 15:38
> To: Keith Zhao <keith.z...@starfivetech.com>; devicet...@vger.kernel.org;
> dri-devel@lists.freedesktop.org
> Cc: andrzej.ha...@intel.com; neil.armstr...@linaro.org; rf...@kernel.org;
> laurent.pinch...@ideasonboard.com; jo...@kwiboo.se;
> jernej.skra...@gmail.com; maarten.lankho...@linux.intel.com;
> mrip...@kernel.org; tzimmerm...@suse.de; airl...@gmail.com;
> sim...@ffwll.ch; r...@kernel.org; krzk...@kernel.org; conor...@kernel.org;
> h...@rock-chips.com; he...@sntech.de; andy....@rock-chips.com; William Qiu
> <william....@starfivetech.com>; Xingyu Wu <xingyu...@starfivetech.com>;
> ker...@esmil.dk; paul.walms...@sifive.com; pal...@dabbelt.com;
> a...@eecs.berkeley.edu; p.za...@pengutronix.de; Changhuang Liang
> <changhuang.li...@starfivetech.com>; Jack Zhu <jack....@starfivetech.com>;
> linux-ker...@vger.kernel.org
> Subject: Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.
>
> On 20/11/2024 07:18, keith zhao wrote:
> > + /* Unmute hotplug interrupt */
> > + hdmi_modb(hdmi, HDMI_STATUS, m_MASK_INT_HOTPLUG,
> > +v_MASK_INT_HOTPLUG(1));
> > +
> > + ret = devm_request_threaded_irq(hdmi->dev, irq, inno_hdmi_hardirq,
> > + inno_hdmi_irq, IRQF_SHARED,
> > + dev_name(hdmi->dev), hdmi);
> > + return ret;
> > +}
> > +EXPORT_SYMBOL_GPL(inno_hdmi_bind);
> > +
> > +MODULE_AUTHOR("Keith Zhao <keithz...@starfivetech.com>");
> > +MODULE_DESCRIPTION("INNO HDMI transmitter driver");
> > +MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:inno-hdmi");
>
> You should not need MODULE_ALIAS() in normal cases. If you need it, usually it
> means your device ID table is wrong (e.g. misses either entries or
> MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute for incomplete
> ID table.
>
Thank you for your suggestion!
I will review the device ID table to ensure its completeness
and avoid using MODULE_ALIAS().
>
> Best regards,
> Krzysztof
