> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
> Sent: Tuesday, May 17, 2022 8:04 PM
> To: Neal Liu <neal_...@aspeedtech.com>; Greg Kroah-Hartman
> <gre...@linuxfoundation.org>; Rob Herring <robh...@kernel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski...@linaro.org>; Joel Stanley <j...@jms.id.au>;
> Andrew Jeffery <and...@aj.id.au>; Felipe Balbi <ba...@kernel.org>; Sumit
> Semwal <sumit.sem...@linaro.org>; Christian König
> <christian.koe...@amd.com>; Geert Uytterhoeven <ge...@linux-m68k.org>;
> Li Yang <leoyang...@nxp.com>
> Cc: linux-asp...@lists.ozlabs.org; linux-...@vger.kernel.org;
> devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> linux-ker...@vger.kernel.org; linux-me...@vger.kernel.org;
> dri-devel@lists.freedesktop.org; linaro-mm-...@lists.linaro.org
> Subject: Re: [PATCH v2 3/3] dt-bindings: usb: add documentation for aspeed
> udc
>
> On 17/05/2022 10:25, Neal Liu wrote:
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - interrupts
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/aspeed-clock.h>
> > + usb: usb@1e6a2000 {
> > + compatible = "aspeed,ast2600-udc";
>
> Sorry for not noticing it earlier - slipped through the cracks. You use here
> unusual indentation (not matching the rest of the example - above is 4 spaces,
> here is 7 or 8).
>
> Just keep 4 spaces for DTS example.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
>
Got it. I'll revise it for next patch.
Thanks for your review.
> Best regards,
> Krzysztof
