On Thu, Nov 26, 2020 at 8:43 AM Lee Jones <lee.jo...@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/iceland_smumgr.c: In > function ‘iceland_thermal_setup_fan_table’: > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/iceland_smumgr.c:2093:6: > warning: variable ‘res’ set but not used [-Wunused-but-set-variable] > > Cc: Evan Quan <evan.q...@amd.com> > Cc: Alex Deucher <alexander.deuc...@amd.com> > Cc: "Christian König" <christian.koe...@amd.com> > Cc: David Airlie <airl...@linux.ie> > Cc: Daniel Vetter <dan...@ffwll.ch> > Cc: Huang Rui <ray.hu...@amd.com> > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jo...@linaro.org> > --- > drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c > b/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c > index 6a0f581de999b..2da5225eafbb8 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c > +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c > @@ -2090,7 +2090,6 @@ static int iceland_thermal_setup_fan_table(struct > pp_hwmgr *hwmgr) > uint32_t t_diff1, t_diff2, pwm_diff1, pwm_diff2; > uint16_t fdo_min, slope1, slope2; > uint32_t reference_clock; > - int res; > uint64_t tmp64; > > if (!phm_cap_enabled(hwmgr->platform_descriptor.platformCaps, > PHM_PlatformCaps_MicrocodeFanControl)) > @@ -2154,7 +2153,7 @@ static int iceland_thermal_setup_fan_table(struct > pp_hwmgr *hwmgr) > > /* fan_table.FanControl_GL_Flag = 1; */ > > - res = smu7_copy_bytes_to_smc(hwmgr, smu7_data->fan_table_start, > (uint8_t *)&fan_table, (uint32_t)sizeof(fan_table), SMC_RAM_END); > + smu7_copy_bytes_to_smc(hwmgr, smu7_data->fan_table_start, (uint8_t > *)&fan_table, (uint32_t)sizeof(fan_table), SMC_RAM_END); >
Should probably just return the error. I'll fix it up. Thanks! Alex > return 0; > } > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
