On Thu, Nov 26, 2020 at 8:43 AM Lee Jones <lee.jo...@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppevvmath.h: In function
> ‘fMultiply’:
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppevvmath.h:336:22:
> warning: variable ‘Y_LessThanOne’ set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppevvmath.h:336:7: warning:
> variable ‘X_LessThanOne’ set but not used [-Wunused-but-set-variable]
>
> Cc: Evan Quan <evan.q...@amd.com>
> Cc: Alex Deucher <alexander.deuc...@amd.com>
> Cc: "Christian König" <christian.koe...@amd.com>
> Cc: David Airlie <airl...@linux.ie>
> Cc: Daniel Vetter <dan...@ffwll.ch>
> Cc: amd-...@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jo...@linaro.org>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h
> b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h
> index 8f50a038396ce..dac29fe6cfc6f 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h
> @@ -333,14 +333,14 @@ static fInt fMultiply (fInt X, fInt Y) /* Uses 64-bit
> integers (int64_t) */
> {
> fInt Product;
> int64_t tempProduct;
> +
> + /*The following is for a very specific common case: Non-zero number
> with ONLY fractional portion*/
> + /* TEMPORARILY DISABLED - CAN BE USED TO IMPROVE PRECISION
> bool X_LessThanOne, Y_LessThanOne;
>
> X_LessThanOne = (X.partial.real == 0 && X.partial.decimal != 0 &&
> X.full >= 0);
> Y_LessThanOne = (Y.partial.real == 0 && Y.partial.decimal != 0 &&
> Y.full >= 0);
>
> - /*The following is for a very specific common case: Non-zero number
> with ONLY fractional portion*/
> - /* TEMPORARILY DISABLED - CAN BE USED TO IMPROVE PRECISION
> -
> if (X_LessThanOne && Y_LessThanOne) {
> Product.full = X.full * Y.full;
> return Product
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
