Hi Daniel, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.2-rc1 next-20190520] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-notifier-begone/20190521-021841 config: x86_64-randconfig-x006-201920 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/video/fbdev/core/fbmem.c: In function 'fb_set_suspend': >> drivers/video/fbdev/core/fbmem.c:1908:3: error: too many arguments to >> function 'fbcon_suspended' fbcon_suspended(info); ^~~~~~~~~~~~~~~ In file included from drivers/video/fbdev/core/fbmem.c:35:0: include/linux/fbcon.h:18:20: note: declared here static inline void fbcon_suspended(void) {} ^~~~~~~~~~~~~~~ >> drivers/video/fbdev/core/fbmem.c:1912:3: error: too many arguments to >> function 'fbcon_resumed' fbcon_resumed(info); ^~~~~~~~~~~~~ In file included from drivers/video/fbdev/core/fbmem.c:35:0: include/linux/fbcon.h:19:20: note: declared here static inline void fbcon_resumed(void) {} ^~~~~~~~~~~~~ vim +/fbcon_suspended +1908 drivers/video/fbdev/core/fbmem.c 1893 1894 /** 1895 * fb_set_suspend - low level driver signals suspend 1896 * @info: framebuffer affected 1897 * @state: 0 = resuming, !=0 = suspending 1898 * 1899 * This is meant to be used by low level drivers to 1900 * signal suspend/resume to the core & clients. 1901 * It must be called with the console semaphore held 1902 */ 1903 void fb_set_suspend(struct fb_info *info, int state) 1904 { 1905 WARN_CONSOLE_UNLOCKED(); 1906 1907 if (state) { > 1908 fbcon_suspended(info); 1909 info->state = FBINFO_STATE_SUSPENDED; 1910 } else { 1911 info->state = FBINFO_STATE_RUNNING; > 1912 fbcon_resumed(info); 1913 } 1914 } 1915 EXPORT_SYMBOL(fb_set_suspend); 1916 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
