Hi Daniel, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.2-rc1 next-20190520] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-notifier-begone/20190521-021841 config: x86_64-randconfig-x004-201920 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/video/fbdev/neofb.c: In function 'neofb_remove': >> drivers/video/fbdev/neofb.c:2130:7: error: void value not ignored as it >> ought to be if (unregister_framebuffer(info)) ^~~~~~~~~~~~~~~~~~~~~~ vim +2130 drivers/video/fbdev/neofb.c ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2117 48c68c4f drivers/video/neofb.c Greg Kroah-Hartman 2012-12-21 2118 static void neofb_remove(struct pci_dev *dev) ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2119 { ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2120 struct fb_info *info = pci_get_drvdata(dev); ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2121 ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2122 DBG("neofb_remove"); ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2123 ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2124 if (info) { ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2125 /* ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2126 * If unregister_framebuffer fails, then ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2127 * we will be leaving hooks that could cause ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2128 * oopsen laying around. ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2129 */ ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 @2130 if (unregister_framebuffer(info)) ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2131 printk(KERN_WARNING ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2132 "neofb: danger danger! Oopsen imminent!\n"); ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2133 ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2134 neo_unmap_video(info); ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2135 fb_destroy_modedb(info->monspecs.modedb); ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2136 neo_unmap_mmio(info); ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2137 neo_free_fb_info(info); ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2138 } ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2139 } ^1da177e drivers/video/neofb.c Linus Torvalds 2005-04-16 2140 :::::: The code at line 2130 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds <torva...@ppc970.osdl.org> :::::: CC: Linus Torvalds <torva...@ppc970.osdl.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
