Hi, On Tue, 2019-02-26 at 15:25 +0100, Maxime Ripard wrote: > Our clock rate variables are getting pretty close to the LONG_MAX / ULONG_MAX > limit, especially since we will start doing arithmetic on it. Move those > types to unsigned long long to be sure we don't overflow their type. > > Signed-off-by: Maxime Ripard <maxime.rip...@bootlin.com>
Reviewed-by: Paul Kocialkowski <paul.kocialkow...@bootlin.com> Cheers, Paul > --- > drivers/gpu/drm/sun4i/sun4i_rgb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c > b/drivers/gpu/drm/sun4i/sun4i_rgb.c > index 8a43ed46af82..893b6e6d4d85 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c > +++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c > @@ -60,8 +60,8 @@ static enum drm_mode_status sun4i_rgb_mode_valid(struct > drm_encoder *crtc, > struct sun4i_tcon *tcon = rgb->tcon; > u32 hsync = mode->hsync_end - mode->hsync_start; > u32 vsync = mode->vsync_end - mode->vsync_start; > - unsigned long rate = mode->clock * 1000; > - long rounded_rate; > + unsigned long long rate = mode->clock * 1000; > + unsigned long long rounded_rate; > > DRM_DEBUG_DRIVER("Validating modes...\n"); > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel