Hi Maxime, I love your patch! Yet something to improve:
[auto build test ERROR on ] url: https://github.com/0day-ci/linux/commits/Maxime-Ripard/drm-sun4i-rgb-Relax-the-pixel-clock-check/20190227-012757 base: config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.2.0 make.cross ARCH=arm64 All errors (new ones prefixed by >>): >> drivers/gpu//drm/sun4i/sun4i_rgb.c:62:1: error: unknown type name 'DEFINE'; >> did you mean 'EMFILE'? DEFINE SUN4I_RGB_DOTCLOCK_TOLERANCE 5 ^~~~~~ EMFILE drivers/gpu//drm/sun4i/sun4i_rgb.c:62:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before numeric constant DEFINE SUN4I_RGB_DOTCLOCK_TOLERANCE 5 ^ drivers/gpu//drm/sun4i/sun4i_rgb.c:191:16: error: 'sun4i_rgb_mode_valid' undeclared here (not in a function); did you mean 'sun4i_rgb_con_funcs'? .mode_valid = sun4i_rgb_mode_valid, ^~~~~~~~~~~~~~~~~~~~ sun4i_rgb_con_funcs vim +62 drivers/gpu//drm/sun4i/sun4i_rgb.c 55 56 /* 57 * VESA DMT defines a tolerance of 0.5% on the pixel clock, while the 58 * CVT spec reuses that tolerance in its examples, so it looks to be a 59 * good default tolerance for the EDID-based modes. Define it to 5 per 60 * mille to avoid floating point operations. 61 */ > 62 DEFINE SUN4I_RGB_DOTCLOCK_TOLERANCE 5 63 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
