The preferred mode typically didn't end up first, since the function
drm_mode_connector_list_update() reordered the modes.

Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
Reviewed-by: Sinclair Yeh <syeh at vmware.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c 
b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index ae87e7e..ef605b6 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -1554,11 +1554,9 @@ int vmw_du_connector_fill_modes(struct drm_connector 
*connector,
                drm_mode_probed_add(connector, mode);
        }

-       /* Move the prefered mode first, help apps pick the right mode. */
-       if (du->pref_mode)
-               list_move(&du->pref_mode->head, &connector->probed_modes);
-
        drm_mode_connector_list_update(connector, true);
+       /* Move the prefered mode first, help apps pick the right mode. */
+       drm_mode_sort(&connector->modes);

        return 1;
 }
-- 
2.1.0


Reply via email to