Re: [Dovecot] Monitoring Recomendations

[Timo Sirainen]

On Fri, 2007-06-29 at 10:45 -0700, Dehnert James Sr wrote:
> I believe that Dovecot is running just fine, but I need some metrics  
> to prove that to the users.

You could for example patch rawlog to log timestamps before each
input/output packet so you can see how long it takes for Dovecot to
reply to commands. If most of the time is spent waiting for incoming
commands then the problem isn't with Dovecot.

Attached a patch (untested though), and
http://dovecot.org/bugreport.html#sniffing explains how to enable
rawlog.

If the problem isn't with Dovecot, maybe your users have some software
firewall on the way that slows everything down.


diff -r 87d0ae7fbe12 src/util/rawlog.c
--- a/src/util/rawlog.c	Fri Jul 13 01:46:26 2007 +0300
+++ b/src/util/rawlog.c	Fri Jul 13 02:10:31 2007 +0300
@@ -40,6 +40,7 @@ struct rawlog_proxy {
 	enum rawlog_flags flags;
 
 	time_t last_write;
+	unsigned int last_in_lf:1;
 	unsigned int last_out_lf:1;
 };
 
@@ -76,8 +77,21 @@ static void proxy_write_in(struct rawlog
 static void proxy_write_in(struct rawlog_proxy *proxy,
 			   const void *data, size_t size)
 {
+	struct tm *tm;
+	char buf[256];
+
 	if (proxy->fd_in == -1 || size == 0)
 		return;
+
+	if (proxy->last_in_lf &&
+	    (proxy->flags & RAWLOG_FLAG_LOG_TIMESTAMPS) != 0) {
+		tm = localtime(&ioloop_time);
+
+		if (strftime(buf, sizeof(buf), TIMESTAMP_FORMAT, tm) <= 0)
+			i_fatal("strftime() failed");
+		if (write_full(proxy->fd_out, buf, strlen(buf)) < 0)
+			i_fatal("Can't write to log file: %m");
+	}
 
 	if (write_full(proxy->fd_in, data, size) < 0) {
 		/* failed, disable logging */
@@ -85,6 +99,7 @@ static void proxy_write_in(struct rawlog
 		(void)close(proxy->fd_in);
 		proxy->fd_in = -1;
 	}
+	proxy->last_in_lf = ((const unsigned char *)buf)[size-1] == '\n';
 }
 
 static void proxy_write_out(struct rawlog_proxy *proxy,
@@ -97,8 +112,7 @@ static void proxy_write_out(struct rawlo
 		return;
 
 	if (proxy->last_out_lf &&
-	    (proxy->flags & RAWLOG_FLAG_LOG_TIMESTAMPS) != 0 &&
-	    ioloop_time - proxy->last_write >= TIMESTAMP_WAIT_TIME) {
+	    (proxy->flags & RAWLOG_FLAG_LOG_TIMESTAMPS) != 0) {
 		tm = localtime(&ioloop_time);
 
 		if (strftime(buf, sizeof(buf), TIMESTAMP_FORMAT, tm) <= 0)

signature.asc
Description: This is a digitally signed message part