On Thu, 2007-06-14 at 15:33 +0200, Erland Nylend wrote: > On 2007-06-13, 14:29, Timo Sirainen wrote: > > If not, I'd have to create some debug patches to find out which function > > is doing this. > > I would appreciate that very much. I still see quite a few of these > "unknown error" -lines in the logs ..
Well, attached is the first one. When you tell me which one of those functions failed I'll send another patch.. > Another thing is that maybe deliver should return a "tempfail" exit > code to postfix in these cases, instead of sending bounce messages. Fixed: http://hg.dovecot.org/dovecot-1.0/rev/1ffe49573721
diff -r 0f40f19d2ae4 src/deliver/deliver.c
--- a/src/deliver/deliver.c Thu Jun 14 14:53:47 2007 +0300
+++ b/src/deliver/deliver.c Thu Jun 14 21:45:38 2007 +0300
@@ -129,14 +129,20 @@ int deliver_save(struct mail_storage *st
kw = strarray_length(keywords) == 0 ? NULL :
mailbox_keywords_create(t, keywords);
- if (mailbox_copy(t, mail, flags, kw, NULL) < 0)
+ if (mailbox_copy(t, mail, flags, kw, NULL) < 0) {
ret = mail->expunged ? -2 : -1;
+ if (ret < 0)
+ i_error("mailbox_copy() failed");
+ }
mailbox_keywords_free(t, &kw);
if (ret < 0)
mailbox_transaction_rollback(&t);
- else
+ else {
ret = mailbox_transaction_commit(&t, 0);
+ if (ret < 0)
+ i_error("mailbox_transaction_commit() failed");
+ }
msgid = mail_get_first_header(mail, "Message-ID");
msgid = msgid == NULL ? "" : str_sanitize(msgid, 80);
signature.asc
Description: This is a digitally signed message part
