On Wed, Aug 26, 2009 at 6:49 PM, Peter2108<pe...@monicol.co.uk> wrote:
>
> I'm trying to help fix but #6138. I've done a patch for the code and a
> separate test.py module. But someone ('Alex') added a request to
> "Please put the tests in the same diff as the patch itself, it is
> possible to use svn add locally". I'm at a loss here I'm afraid. The
> only way I know to generate a single diff that included a patch to
> trunk/django/forms/forms.py and to the trunk/tests/regressiontests/
> forms/forms.py is to set up subversion in the 'trunk' folder. But then
> can one apply the patch if one does not have all that stuff?
I'm not sure I understand the source of your confusion.
The Django install instructions indicate that if you want to use the
Django development code, you should have a checkout of the 'trunk'
director i.e.,:
svn co http://code.djangoproject.com/svn/django/trunk/ django-trunk
In this example, django-trunk is a complete checkout of the Django
code, and it is the directory against which you should be generating
your diff.
> Also where should one place this test - in trunk/tests/
> regressiontests/forms/forms.py or in trunk/tests/regressiontests/
> forms/error_messages.py or in a separate module even?
Add the patch wherever seems appropriate. Look around for a similar
tests, and put your tests alongside those. If there really is nothing
similar, add a new test module.
However, don't get too hung up on exactly where to put the tests. If
the location you pick isn't ideal, it will get moved by the committer
when your patch is added to trunk. As a patch contributor, the most
important step is to write the test in the first place, and to put it
somewhere so that it can be executed to demonstrate the validity of
your patch.
Yours,
Russ Magee %-)
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this group, send email to django-users@googlegroups.com
To unsubscribe from this group, send email to
django-users+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---
