On Wed, Aug 26, 2009 at 6:49 AM, Peter2108 <pe...@monicol.co.uk> wrote:
>
> I'm trying to help fix but #6138. I've done a patch for the code and a
> separate test.py module. But someone ('Alex') added a request to
> "Please put the tests in the same diff as the patch itself, it is
> possible to use svn add locally". I'm at a loss here I'm afraid. The
> only way I know to generate a single diff that included a patch to
> trunk/django/forms/forms.py and to the trunk/tests/regressiontests/
> forms/forms.py is to set up subversion in the 'trunk' folder. But then
> can one apply the patch if one does not have all that stuff?
>
I don't really understand what you are asking. I don't know who the "one"
is in your last question nor what "all that stuff" is.
Yes, you are expected to generate diffs from the root of trunk, as requested
in the third bullet here:
http://docs.djangoproject.com/en/dev/internals/contributing/#patch-style
Anyone regularly contributing or using patches from trac will generally be
using an svn checkout of trunk, or a git (or some other DVCS) clone of the
same, so I don't understand what the problem is you are concerned with here?
A committer when considering the patch will expect to be able to apply it to
the root of the trunk. If you don't generate diffs from the root, or post
multiple diffs to a ticket that need all be applied, then the committer has
to figure out which all pieces are supposed to go together and where to put
each one. This is much more likely to result in errors than a single diff
generated from the root of the trunk, thus we request single diffs generated
from the root of the trunk.
>
> Also where should one place this test - in trunk/tests/
> regressiontests/forms/forms.py or in trunk/tests/regressiontests/
> forms/error_messages.py or in a separate module even?
>
Whichever seems like the best match. Without looking at the ticket or
existing tests too closely, I'd guess the extending the existing
error_messages test would be fine.
Karen
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this group, send email to django-users@googlegroups.com
To unsubscribe from this group, send email to
django-users+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---
