On 10/9/07, Brian Rosner <[EMAIL PROTECTED]> wrote: > > On 2007-10-09 14:39:57 -0600, "Joseph Kocherhans" <[EMAIL PROTECTED]> said: > > > > > On 10/9/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > >> > >> This raises some alarm bells. Why on earth are we futzing around in > >> ChangeManipulators here? They are entirely oldforms-related and the > >> whole point is to remove any reliance on them. > >> > >> This might well be a bug and in an area that just hasn't been addressed > >> yet, since I'd wager not a lot of regular testing is going on with > >> 100,000 objects in those cases. Probably worth a ticket, Karen. > > > > Yeah, there is some hideousness left that I forgot about. Specifically > > here [1] and here [2]. There are actually quite a few places where > > newforms-admin stuff calls out to old code that kinda works, but needs > > to be rewritten. I have not done much scouring yet to clean all of > > this up. It'll probably be November before I have a lot of time to > > work on it again though :( Really, the render_change_form function > > needs to be moved into the ModelAdmin class and the manipulator stuff > > needs to be removed from it. Patches are welcome. (And no Malcolm, > > that's not directed at you ;) > > Your wish is my command ;) > > http://code.djangoproject.com/ticket/5720
Man, now I have to put my money where my mouth is. :) Thank you much. Committed in [6470]. Just FYI I left the index view there. The patch had removed it. Yes, it should die, but it's death belongs in a separate commit. I'm just going to leave it there until I get around to ripping out a bunch of other stuff that is probably no longer used. Joseph --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~----------~----~----~----~------~----~------~--~---
