Aseem, I had a quick look at your Django app and here are some of my observations:
1. Most Django apps have a standard layout with the app in a directory named after itself. See django-taggit <https://github.com/alex/django-taggit> for instance. 2. You have made some unconventional choices which needs to be explained like using CharField instead of URLField, not using relative paths in imports etc. 3. An app must do one thing really well in order to be most reusable. I believe autocomplete and opening a web browser don't belong to a bookmarking app. 4. There needs to be more unit tests and documentation to increase confidence of other developers in using the app. Sorry, if I have misunderstood the objectives of your project, but these things stood out to me. Cheers, Arun On Saturday, 7 June 2014 15:37:52 UTC+5:30, Aseem Bansal wrote: > > I last asked for a review around two weeks back for my project. Is anyone > interested to give a second review for this project? > > https://github.com/anshbansal/Bookmarker > > The last thread was here > https://groups.google.com/forum/#!topic/django-users/ob4fXz3GF9w in case > someone wants to see that I actually respond to people's comments instead > of just wasting their time. > > From last time I have done these changes - > 1 Bookmark update as per categories is now working > 2 Used templates to make some things simpler to understand > 3 Refactoring of view.py to get reusable components > 4 Refactored jquery to make it cleaner so it is actually possible to read > it > 5 Added CDN of librarires and added backup in case no internet is present > > > My main concern currently is that this project is turning out to have a > lot more jQuery than Python/HTML. Am I designing this incorrectly? I > understand that as my requirements are mostly asynchronous so there is a > need for javascript but redundancy like hard-coding URLs for autocomplete > in javascript is bothering me. Also am I over-engineering the Javascript? > -- You received this message because you are subscribed to the Google Groups "Django users" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-users+unsubscr...@googlegroups.com. To post to this group, send email to django-users@googlegroups.com. Visit this group at http://groups.google.com/group/django-users. To view this discussion on the web visit https://groups.google.com/d/msgid/django-users/ef8c5e0c-373d-438c-bd71-e3d9e753653c%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
