#37093: Adjust GitHub PR description template + bot check error emoji
--------------------------------------+------------------------------------
Reporter: Stephanie Goulet | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: 6.0
Severity: Normal | Resolution:
Keywords: PR, GitHub | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Stephanie Goulet):
Replying to [comment:2 Jacob Walls]:
> Are you interested in submitting a PR?
Sure, I can try
Based on what's been said so far: [https://www.diffchecker.com/EiWV1Bg9/
Updated V2 of draft edits].
- Added as a comment but before the last four items instead of two (blighj
seems right to me but let me know if I'm misunderstanding anything)
- Also removed the "please" in the AI section for consistency across all
the comment instructions
Had another thought which is one thing that moving the branch description
to a comment does is make it so the comment will remain in submitted PRs.
This is consistent with other sections having comments so maybe it doesn't
matter, but if the reviewers care to keep it as not having a comment in
the branch description for submitted PRs, an alternative edit could be:
Update the section to be:
{{{
#### Branch description
Replace this text with a concise overview of the issue or rationale behind
the proposed changes (5 word minimum).
}}}
Which would also require updating the
[https://github.com/django/django/blob/4d455ae2d7689ce066dfffef9fc29a6f6d3ed33e/scripts/pr_quality/check_pr.py#L332
branch description check] just so that the placeholder text is matching
against the new version of the placeholder text.
--
Ticket URL: <https://code.djangoproject.com/ticket/37093#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019e1bbdf4e1-9013f9d9-0381-40cb-ac78-93d5f5f27b98-000000%40eu-central-1.amazonses.com.
