#37093: Adjust GitHub PR description template + bot check error emoji
--------------------------------------+------------------------------------
Reporter: Stephanie Goulet | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: 6.0
Severity: Normal | Resolution:
Keywords: PR, GitHub | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by blighj):
Replying to [comment:2 Jacob Walls]:
> A note: the automated PR quality check
[https://github.com/django/django/blob/4d455ae2d7689ce066dfffef9fc29a6f6d3ed33e/scripts/pr_quality/check_pr.py#L410
expects only the last two checkboxes to be optional], so I would suggest
making that explicit in the checklist somehow.
My understanding was that the bot is checking the first five are checked,
which would make it the last four, not the last two, that the bot sees as
optional.
I'm open to being corrected on that, but it looks right from the code and
those last four being if applicable makes sense
--
Ticket URL: <https://code.djangoproject.com/ticket/37093#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019e1849ab34-9c03a3ee-c204-4e05-85e7-3c0c1e0e4740-000000%40eu-central-1.amazonses.com.
