#33331: Improve exception handling with `cursor.close()` after errors
-------------------------------------+-------------------------------------
Reporter: Daniel Hahler | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: 3.2
(models, ORM) |
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson):
Hi Daniel.
It wasn't really that 6b6be692fcd102436c7abef1d7b3fa1d37ad4bdf ignored all
exceptions. Rather it stopped the source exception being masked, with the
explicit intention that the new chained behaviour would be preferred when
it was available:
{{{
# Ignore clean up errors and raise the original error instead.
# Python 2 doesn't chain exceptions. Remove this error
# silencing when dropping Python 2 compatibility.
}}}
Given that it's clearly not a regression in
d170c63351944fd91b2206d10f89e7ff75b53b76 — that was the intended change
all along.
You're then asking for a change in behaviour to **remove** information
from the traceback. Maybe that's OK if there's a good reason, but
otherwise the presumption would be wontfix.
I'm not sure about the patch itself: it would be easier to consider in a
fresh PR, with a regression test.
--
Ticket URL: <https://code.djangoproject.com/ticket/33331#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.9793b2e73455a0a4ee494d6db7e979d8%40djangoproject.com.
