#32445: LiveServerThreadTest.test_closes_connections() doesn't pass with non-in-
memory SQLite
-------------------------------------+-------------------------------------
Reporter: Chris Jerdonek | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Testing framework | Version: 3.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
SQLite,is_usable,LiveServerThread |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
> I guess this means that Django's CI doesn't check non-in-memory SQLite.
That's True, but I think it's still worth fixing. There is an interesting
[https://github.com/django/django/pull/7096#discussion_r74955788
discussion] about this test in the original PR. I think we should remove
`test_closes_connections()` from `django_test_skips()` and use
`@skipUnlessDBFeature('test_db_allows_multiple_connections')` instead.
--
Ticket URL: <https://code.djangoproject.com/ticket/32445#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.0f85cf32eeee2cdf36b9af1c2bd8773b%40djangoproject.com.
