#32445: LiveServerThreadTest.test_closes_connections() doesn't pass with non-in-
memory SQLite
-------------------------------------+-------------------------------------
Reporter: Chris | Owner: nobody
Jerdonek |
Type: | Status: new
Uncategorized |
Component: Testing | Version: 3.1
framework | Keywords:
Severity: Normal | SQLite,is_usable,LiveServerThread
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
I noticed that `LiveServerThreadTest.test_closes_connections()` doesn't
seem to pass when using non-in-memory SQLite. It's only configured to be
skipped
[https://github.com/django/django/blob/3fa1ed53be370f4b1a94d78b56ff30d23b131623/django/db/backends/sqlite3/features.py#L75-L81
for in-memory SQLite]. It doesn't pass because the test has the
[https://github.com/django/django/blob/3fa1ed53be370f4b1a94d78b56ff30d23b131623/tests/servers/test_liveserverthread.py#L24
following line]:
{{{#!python
self.assertFalse(conn.is_usable())
}}}
But SQLite's `is_usable()` has a hard-coded return value of `True`:
https://github.com/django/django/blob/3fa1ed53be370f4b1a94d78b56ff30d23b131623/django/db/backends/sqlite3/base.py#L387-L388
I guess this means that Django's CI doesn't check non-in-memory SQLite. If
it's true that Django doesn't check this case, I'm not sure if that means
it doesn't need to be fixed.
--
Ticket URL: <https://code.djangoproject.com/ticket/32445>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.b7e78f018bff34264e0f918b95363625%40djangoproject.com.
