#30076: get_FOO_display missing if field choices is specified but falsey
-------------------------------------+-------------------------------------
Reporter: Joshua Cannon | Owner: Joshua
| Cannon
Type: Bug | Status: assigned
Component: Database layer | Version: 2.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: choices | Triage Stage: Accepted
get_FOO_display |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Joshua Cannon:
Old description:
> Since `Field` checks if `choices` is truthy
> [https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L745
> code] instead of checking against `None`, some model instances aren't
> receiving the `get_FOO_display` method.
>
> Usually the culprit is `Field` subclasses doing some kind of dynamic
> choice generation, providing `choices=()` as a sort of fallback. Since
> `()` is an empty tuple that is falsey, the method never gets added.
>
> So far I've seen 2 libraries that have this "issue", which is likely a
> small set.
> - [https://github.com/jazzband/django-model-
> utils/blob/master/model_utils/fields.py#L75 django-model-utils] just
> gives some dummy choices.
> - [https://github.com/craigds/django-typed-models/issues/47 django-
> typed-models] doesn't have a fix yet.
New description:
Since `Field` checks if `choices` is truthy
[https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L745
code] instead of checking against `None`, some model instances aren't
receiving the `get_FOO_display` method.
Usually the culprit is `Field` subclasses doing some kind of dynamic
choice generation, providing `choices=()` as a sort of fallback. Since
`()` is an empty tuple that is falsy, the method never gets added.
So far I've seen 2 libraries that have this "issue", which is likely a
small set.
- [https://github.com/jazzband/django-model-
utils/blob/master/model_utils/fields.py#L75 django-model-utils] just gives
some dummy choices.
- [https://github.com/craigds/django-typed-models/issues/47 django-
typed-models] doesn't have a fix yet.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/30076#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.61382b94c3ebc75a016ca86edce7786e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
