#30076: get_FOO_display missing if field choices is specified but falsey
-------------------------------------+-------------------------------------
Reporter: Joshua | Owner: nobody
Cannon |
Type: Bug | Status: assigned
Component: Database | Version: 2.1
layer (models, ORM) | Keywords: choices
Severity: Normal | get_FOO_display
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
Since `Field` checks if `choices` is truthy
[https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L745
code] instead of checking against `None`, some model instances aren't
receiving the `get_FOO_display` method.
Usually the culprit is `Field` subclasses doing some kind of dynamic
choice generation, providing `choices=()` as a sort of fallback. Since
`()` is an empty tuple that is falsey, the method never gets added.
So far I've seen 2 libraries that have this "issue", which is likely a
small set.
- [https://github.com/jazzband/django-model-
utils/blob/master/model_utils/fields.py#L75 django-model-utils] just gives
some dummy choices.
- [https://github.com/craigds/django-typed-models/issues/47 django-
typed-models] doesn't have a fix yet.
--
Ticket URL: <https://code.djangoproject.com/ticket/30076>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/053.42fa560ee83fdecbccf32e464403dbba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
