#29917: Admin actions are duplicated when using model admins with inheritance
-------------------------------------+------------------------------------
Reporter: Matthias Kestenholz | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Comment (by Carlton Gibson):
So, following the discussion of the breaking change in the PRs, digging
into the history, it seems the MRO based collection of actions has been in
place for the entire history of the feature..
It was introduced in #10505 as part of the original feature for v1.1. (The
[https://github.com/django/django/commit/44f3080226#diff-
3c42de3e53aba87b32c494f995a728dfR423 line in the diff].)
`get_actions()` was
[https://code.djangoproject.com/attachment/ticket/10505/admin-
actions.9.diff introduced explicitly] to allow collection of actions from
superclasses.
Given the contributors to #10505, and that it was a conscious decision on
their part, I'm don't feel we can just change the behaviour as part of a
bug fix.
Maybe there's a case for a change, but that should be made separately.
(Currently the behaviour is not tested, but with
[https://github.com/django/django/pull/10607 PR10607] it would be, and not
documented, but a long-overdue paragraph could be added.)
--
Ticket URL: <https://code.djangoproject.com/ticket/29917#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.903ac12d71e55ab152303bcaf7758b3f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
