#29917: admin.E130 (__name__ uniqueness) regression
-------------------------------------+-------------------------------------
Reporter: Matthias Kestenholz | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* status: new => closed
* resolution: => needsinfo
Comment:
Hmmm. I'm not at all sure why we'd apply your patch.
I'm not seeing the issue here.
I don't see a failure adding this test to
`tests/modeladmin/test_actions.py`:
{{{
def test_actions_are_correctly_inherited(self):
class MockRequest:
pass
class AdminWithoutActions(admin.ModelAdmin):
# No actions attribute defined
pass
ma = AdminWithoutActions(Band, admin.AdminSite())
mock_request = MockRequest()
mock_request.GET = {}
mock_request.user = self.superuser
action_names = [a[1] for a in ma._get_base_actions()]
self.assertEqual(action_names, ['delete_selected'])
}}}
If it were picking up the action from the subclass as well as the
superclass we'd expect `delete_selected` to appear twice. This isn't
happening. Thus there must be more going on in your example.
If you can add a test case of this form that reproduces the issue, I'm
happy to re-open and accept the issue if Django is at fault.
(I'm not yet convinced this is really a regression from #29711: it seems
at best it'll have highlighted a latent bug, and since the warning can be
silenced I'm not sure it'd justify blocking a release.)
--
Ticket URL: <https://code.djangoproject.com/ticket/29917#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.75f53dfafa8f5b20018ff5c8e89a604f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
