#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-------------------------------------+-------------------------------------
     Reporter:  Sanyam Khurana       |                    Owner:  Vishvajit
         Type:                       |  Pathak
  Cleanup/optimization               |                   Status:  assigned
    Component:                       |                  Version:  master
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

 * needs_better_patch:  0 => 1


Comment:

 As commented on the pull request, you cannot use the `all_locales`
 variable as a reference as it does not contain new (valid) language codes.
 The modified test in your patch shows a `'Invalid locale en'` message
 which is obviously wrong, isn't it?
 You may try using the
 `django.utils.translation.trans_real.language_code_re` to check the locale
 code syntax.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29712#comment:21>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.7ea63f987fdb0a19a0f57188afc51d69%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to