#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-------------------------------------+-------------------------------------
     Reporter:  Sanyam Khurana       |                    Owner:  Mark
         Type:                       |  Dawson
  Cleanup/optimization               |                   Status:  assigned
    Component:                       |                  Version:  master
  Internationalization               |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Herbert Fortes):

 Hi,

 Here my thoughts:

 language_code_re gets 'pt_BR'. And it does not get 'ZH-CN'. I did this:
 {{{ r'[a-z]{2}(_[A-Z]{2})?' }}}

 It seems to work. But one test prints:
 {{{
 System check identified no issues (0 silenced).
 Invalid locale d
 Invalid locale e
 .................................................
 ----------------------------------------------------------------------
 Ran 49 tests in 1.425s

 OK
 }}}

 I did a check and there is only one line - 740 - that's use
 {{{locale=LOCALE}}}. All
 others use {{{ locale=[LOCALE]}}}.

 What do you think Mark?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29712#comment:29>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.2a5c03b941fcc7bd373effc2d908ea1d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to