#29082: force_bytes from utils.encoding.py produces invalid JSON for 
RequestFactory
---------------------------+--------------------------------------
     Reporter:  Nick       |                    Owner:  nobody
         Type:  Bug        |                   Status:  new
    Component:  Utilities  |                  Version:  2.0
     Severity:  Normal     |               Resolution:
     Keywords:             |             Triage Stage:  Unreviewed
    Has patch:  0          |      Needs documentation:  0
  Needs tests:  0          |  Patch needs improvement:  0
Easy pickings:  0          |                    UI/UX:  0
---------------------------+--------------------------------------

Comment (by Nick):

 I can agree with moving it up a level. Although in that case maybe it is
 worth moving it even further upstream to post:

 
https://github.com/django/django/blob/86de930f413e0ad902e11d78ac988e6743202ea6/django/test/client.py#L334

 We already instantiate a dict here if there is no data - even if it is
 empty - so we are effectively expecting a json body by default.

 encode_data is not used anywhere else at this point and as it is mostly
 concerned with encoding the data from a detected charset instead of
 mutating it's type you could argue that it is also working as expected.

 However I would argue that .post is not working as expected.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29082#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.46386a9c6f06d94d4e6e1f6603e31252%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to